Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the package from LSFClusterManager.jl to LSFClusterManagers.jl #9

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Rename the package from LSFClusterManager.jl to LSFClusterManagers.jl #9

merged 1 commit into from
Jan 6, 2025

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jan 6, 2025 •
edited
Loading

Ref #5.

I think the name of this package should probably be pluralized, based on the package naming guidelines here:

Packages that provide most of their functionality in association with a new type should have pluralized names.

@DrChainsaw
Copy link
Collaborator

Agreed!

@DrChainsaw DrChainsaw merged commit c0fa1ee into master Jan 6, 2025
5 checks passed
@DrChainsaw DrChainsaw deleted the dpa/rename-singular-to-plural branch January 6, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrChainsaw DrChainsaw Awaiting requested review from DrChainsaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @DrChainsaw