Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using ModelParameters.jl for parameters #49

Open
briochemc opened this issue Nov 14, 2020 · 2 comments
Open

Consider using ModelParameters.jl for parameters #49

briochemc opened this issue Nov 14, 2020 · 2 comments

Comments

@briochemc
Copy link
Member

See rafaqz/ModelParameters.jl#8 (comment) for reference.

Maybe try by building a small example AIBECS model manually and go from there.
@briochemc
Copy link
Member Author

Another thing that is sometimes a pain with the current struct implementation is its rigidity. You can't change the parameters' struct on the fly. Maybe a simpler wrapped array type would be better, and more in line with SciML or something like ModelParameters.jl

@briochemc
Copy link
Member Author

Additional note: an important feature would be the ability to read and write csv files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briochemc