Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fft commented code #48

Open
rveltz opened this issue Nov 19, 2022 · 4 comments
Open

fft commented code #48

rveltz opened this issue Nov 19, 2022 · 4 comments
Labels

Comments

@rveltz
Copy link

rveltz commented Nov 19, 2022

Hi,

Why the code about fft is commented?

https://github.com/JuliaMath/AppleAccelerate.jl/blob/master/src/DSP.jl#L420-L422

I would like to test it against FFTW.fft (with plan)

Thanks for your help,

Bests.

@rveltz
Copy link
Author

rveltz commented Dec 15, 2022

Is there an issue with the code?

@ViralBShah
Copy link
Contributor

I'm not sure why it is commented, but it would be great for someone to try it out. Perhaps the DSP capabilities should also be a Pkg Extension, which are loaded when the DSP packages / FFTW etc. are loaded.

@vpuri3
Copy link

vpuri3 commented Aug 8, 2023

fft/dct methods can be placed in an AbstractFFTs extension package. The plans can subtype AbstractFFTs.Plan and so they can support the interface.

@jagoosw
Copy link

jagoosw commented Sep 25, 2023

Hi all,

I've attempted to uncomment and use the code and have put it here, but it seg faults when you call newfft.

Does anyone know if there has been any progress here?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants