-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isunitary
& isorthogonal
functions to LinearAlgebra
stdlib?
#1098
Comments
I could help? |
@PredictiveManish There's no formal assignment. You may submit a PR with the implementations added, along with appropriate tests. I wonder if there is an easy way to check this without verifying |
Is it faster to compute the multiplication Anyway, for certain matrices (e.g., |
I'm not sure how these functions would be used. Symmetry (or Hermitian-ness) is checked exactly, based on the components, and we don't provide an "almost-symmetric check", for good reasons, because bad things can happen when you perturb symmetric matrices out of symmetric matrices. But what do you do with a result like "is orthogonal up to an error"? So it's "not orthogonal", or "almost orthogonal"? I believe somebody has requested adding an orthogonality check function for vectors, but again what do you do with "numerically almost orthogonal vectors"? It's something different when you have an object that comes from an algorithm that is theoretically guaranteed to return orthogonal objects (like columns of I think one would need more background and a very good reason to add such fragile functions, otherwise it could very well be implemented in a few lines in a package. |
I've thinking about that too, @dkarrasch. These functions are implemented in https://github.com/jlapeyre/IsApprox.jl. |
I agree with this. Furthermore, |
Maybe the others are not so easy to implement, but we can add |
@singularitti, the SkewLinearAlgebra.jl package provides an In LinearAlgebra.jl, checking for skew-symmetric matrices seems pretty useless since we have no functions that take advantage of it? One place that might be useful is in |
Would that be possible to do it? We already have something like
ishermitian
.The text was updated successfully, but these errors were encountered: