-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an extension to support ForwardDiff #586
Conversation
Because of the extensive changes on `master`, ForwardDiff no longer works with this package. This add an extension (Julia 1.9+) providing at least basic support.
Thanks for opening this PR! |
That's actually where I started. But I grew to think it might be better this way: ForwardDiff is widely used by a lot of different things, it seems more scalable to have extensions in packages that may have fewer "interop" demands. As a practical matter, ForwardDiff's tests also take a long time to run! But in the end I'm not sure it matters a lot; the extension mechanism ensures the code will be loaded, one way or another. |
Good point about scalability. So the main concern here is the reliability. Do we have a guarantee, with your PR, that Unfortunately I am too unfamiliar with ForwardDiff.jl to know the answer. I see that it is used to define |
I tried the tests you included in your PR and they seem to pass using the PR #593; I will add them to the test suite to keep track of FowardDiff. |
@timholy how is the interaction between IntervalArithmetic (v0.22.14) and ForwardDiff for you? |
I haven't returned to this research topic in a while. I'll get back to it eventually, but for the time being...no idea! 🙂 |
Closing this for the time being 🙂 |
Because of the extensive changes on
master
, ForwardDiff no longer works with this package. This add an extension (Julia 1.9+) providing at least basic support.Note that:
iszero_tuple
JuliaDiff/ForwardDiff.jl#667. I am not sure when there will be a new release of ForwardDiff, but the master branch is now0.11-DEV
.dev ForwardDiff in the
test` foldernightly
or we have to abandontest/Project.toml
and copy everything to the[extras]
section of the mainProject.toml
.So obviously this can't be merged yet, but I thought it would be better to submit it now.