Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JLL version to v3.1.5 #19

Closed
wants to merge 2 commits into from

Conversation

asinghvi17
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.24%. Comparing base (b5462c6) to head (0021660).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/LibRPR.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   24.20%   24.24%   +0.04%     
==========================================
  Files           5        5              
  Lines        1157     1155       -2     
==========================================
  Hits          280      280              
+ Misses        877      875       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@asinghvi17
Copy link
Contributor Author

This seems to work here, and when run locally, but RPRMakie segfaults pretty often with no apparent reason. Seems it'll need to be updated a bit, but given that this works, should we merge?

@SimonDanisch
Copy link
Member

but RPRMakie segfaults pretty often with no apparent reason. Seems it'll need to be updated a bit, but given that this works, should we merge?

Lol :D
We should not merge PRs which "segfault pretty often" ;)

It's not RPRMakie that needs to be adapted, but you need to rewrap for a new jll version with Clang.jl, otherwise all the signatures will be wrong and you'll get - segfaults!
I did that recently, so this PR is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants