Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing of cores not reliable #23

Open
jagot opened this issue Jan 24, 2019 · 2 comments
Open

Printing of cores not reliable #23

jagot opened this issue Jan 24, 2019 · 2 comments
Labels

Comments

@jagot
Copy link
Member

jagot commented Jan 24, 2019

If constructing the configuration for radon with open 6s2 6p6 subshells, the core is incorrectly printed as [Kr]:

julia> c"[Xe] 4f14c 5d10c 6s2 6p6"
[Kr]ᶜ 4d¹⁰ᶜ 4f¹⁴ᶜ 5s²ᶜ 5p⁶ᶜ 5d¹⁰ᶜ 6s² 6p⁶

This is because the 4f14c subshell appears before the 5s2c 5p6c subshells that belong to the [Xe] core, and the printing routine does not consider this.

@mortenpi
Copy link
Member

Going to unsorted configurations (#33) would also fix this I believe, since we'd no longer move the subshells around?

@mortenpi mortenpi added the bug label Mar 24, 2021
@jagot
Copy link
Member Author

jagot commented Dec 12, 2023

Yet another example:

julia> s = rc"[Xe]"
[Xe]ᶜ

julia> s.states[end] = :open
:open

julia> s
[Kr]ᶜ 4d⁶ᶜ 5s²ᶜ 5p⁴ᶜ 4d-⁴ᶜ 5p-² # This is OK

julia> s = only(spin_configurations(rc"[Xe]"))
[Xe]ᶜ

julia> s.states[end] = :open
:open

julia> s
[Xe]ᶜ 5p-(1/2) # This is wrong, should be printed with a [Kr] core, and closed 4d, 5s, 5p subshells and closed 5p-(1/2) orbital

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants