Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase keys in FITSHeader #159

Open
jishnub opened this issue Mar 9, 2021 · 0 comments
Open

Uppercase keys in FITSHeader #159

jishnub opened this issue Mar 9, 2021 · 0 comments

Comments

@jishnub
Copy link
Contributor

jishnub commented Mar 9, 2021

FITS requires the header keywords be in uppercase. I wonder if it makes sense to convert the keys to uppercase while constructing a FITSHeader object? Otherwise the keys written out might differ from the ones read back in, which might cause unexpected bugs.

Alongside this, getindex on a FITSHeader might ignore the case of the key by converting it to uppercase. This will bring it closer to the behavior of astropy.

This might potentially be breaking though, but overall seems like a good change, as the FITSHeader object written out will be identical to the one read back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant