Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PigeonsForwardDiffExt fails to precompile on 1.11.1 #287

Closed
thorek1 opened this issue Oct 17, 2024 · 5 comments · Fixed by #288
Closed

PigeonsForwardDiffExt fails to precompile on 1.11.1 #287

thorek1 opened this issue Oct 17, 2024 · 5 comments · Fixed by #288

Comments

@thorek1
Copy link

thorek1 commented Oct 17, 2024

from my tests:

ERROR: LoadError: The following 1 direct dependency failed to precompile:

PigeonsForwardDiffExt --code-coverage=@/home/runner/work/MacroModelling.jl/MacroModelling.jl --color=yes --check-bounds=yes --warn-overwrite=yes --depwarn=yes --inline=yes --startup-file=no --track-allocation=none --check-bounds=yes --compiled-modules=yes 

Failed to precompile PigeonsForwardDiffExt [c307e446-76ca-5895-84ac-f2b84d8f68d6] to "/home/runner/.julia/compiled/v1.11/PigeonsForwardDiffExt/jl_D2YqBL".
ERROR: LoadError: type Nothing has no field ForwardDiffLogDensity
Stacktrace:
 [1] getproperty(x::Nothing, f::Symbol)
   @ Base ./Base.jl:49
 [2] top-level scope
   @ ~/.julia/packages/Pigeons/pUXew/ext/PigeonsForwardDiffExt/PigeonsForwardDiffExt.jl:24
 [3] include
   @ ./Base.jl:557 [inlined]
 [4] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
   @ Base ./loading.jl:2790
 [5] top-level scope
   @ stdin:5
in expression starting at /home/runner/.julia/packages/Pigeons/pUXew/ext/PigeonsForwardDiffExt/PigeonsForwardDiffExt.jl:1
in expression starting at stdin:
in expression starting at /home/runner/work/_actions/julia-actions/julia-runtest/v1/test_harness.jl:9
@astrozot
Copy link

Something similar for me: I got this error during the precompilation:

pkg> precompile
Precompiling project...
  ✗ Pigeons  PigeonsForwardDiffExt
  0 dependencies successfully precompiled in 9 seconds. 583 already precompiled.

ERROR: The following 1 direct dependency failed to precompile:

PigeonsForwardDiffExt

Failed to precompile PigeonsForwardDiffExt [c307e446-76ca-5895-84ac-f2b84d8f68d6] to "/Users/mlombard/.julia/compiled/v1.11/PigeonsForwardDiffExt/jl_Ot6OBL".
ERROR: LoadError: type Nothing has no field ForwardDiffLogDensity
Stacktrace:
 [1] getproperty(x::Nothing, f::Symbol)
   @ Base ./Base.jl:49
 [2] top-level scope
   @ ~/.julia/packages/Pigeons/pUXew/ext/PigeonsForwardDiffExt/PigeonsForwardDiffExt.jl:24
 [3] include
   @ ./Base.jl:557 [inlined]
 [4] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
   @ Base ./loading.jl:2790
 [5] top-level scope
   @ stdin:5
in expression starting at /Users/mlombard/.julia/packages/Pigeons/pUXew/ext/PigeonsForwardDiffExt/PigeonsForwardDiffExt.jl:1
in expression starting at stdin:

(Gravity) pkg>

@thorek1 thorek1 changed the title PigeonsForwardDiffExt fails to repcompile on 1.11.1 PigeonsForwardDiffExt fails to precompile on 1.11.1 Oct 17, 2024
@miguelbiron
Copy link
Collaborator

Oof! Thanks for reporting. I think this is due to a recent change in LogDensityProblemsAD.jl. Let me investigate.

@miguelbiron
Copy link
Collaborator

Scratch that -- this seems like it is due to a breaking change in 1.11.1 in the way get_extension works---in a patch version release...

@miguelbiron
Copy link
Collaborator

@thorek1 @astrozot the issue is now fixed in the main branch. Just waiting for Julia registrator to do its thing

@miguelbiron
Copy link
Collaborator

Done https://github.com/Julia-Tempering/Pigeons.jl/releases/tag/v0.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants