Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J4 Helix 3 Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given #111

Open
Orgoth opened this issue Jan 28, 2022 · 0 comments

Comments

@Orgoth
Copy link

Orgoth commented Jan 28, 2022

Bug description

helix3.php uses wrong arguments for addStyleSheet() in Line 642 and 648.

self::getInstance()->document->addStyleSheet(JURI::base(true) . '/templates/' . $template . '/css/' . $src, 'text/css', null, $attribs);

self::getInstance()->document->addStyleSheet($src, 'text/css', null, $attribs);

With PHP7.x and Joomla3 this does not impact anything, but if the user upgrades to Joomla4 and PHP8 he will get a error message.

Steps to reproduce

  • setup a server instance with php8.x
  • setup a new joomla4 instance
  • install helix 3
  • set helix3 as default
  • check the frontpage

Expected behavior

No error exception should be thrown.

Screenshots

Screenshot_20220127_151900

Environment

  • Ubuntu server minimal 20.04 LTS
  • PHP 8.x
  • Apache 2.4
  • Mysql 5.x+
  • Joomla 4
@Orgoth Orgoth changed the title J4 Helix Ultima Php8 Gives Error: Implode(): Argument #1 ($pieces) Must Be Of Type Array, String Given J4 Helix Ultima Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given Jan 28, 2022
@Orgoth Orgoth changed the title J4 Helix Ultima Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given J4 Helix 8 Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given Jun 14, 2022
@Orgoth Orgoth changed the title J4 Helix 8 Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given J4 Helix 3 Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant