Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

req: An order has both a relative and an absolute fee. #334

Open
raedah opened this issue Nov 26, 2015 · 8 comments
Open

req: An order has both a relative and an absolute fee. #334

raedah opened this issue Nov 26, 2015 · 8 comments

Comments

@raedah
Copy link
Contributor

raedah commented Nov 26, 2015

Have one order type, that has fields for both relative and absolute fees so that an order can have both a fixed per transaction fee and charge a percentage of the transaction size.

@chris-belcher
Copy link
Collaborator

Linking to #171

@raedah raedah changed the title Req: An order has both a relative and an absolute fee. req: An order has both a relative and an absolute fee. Nov 27, 2015
@adlai
Copy link
Contributor

adlai commented Nov 29, 2015

I'll go full-retard and suggest that both the cjfee and txfee fields should simply allow some reasonably finite combination of integers, floats, operations, and placeholders for variables such as the target amount, byte size of maker inputs, estimated total transaction size, etc.

As a bare minimum, it should be possible to express:

I'll donate to miners ten satoshis per byte for my input utxos, and require fee from the initiator of one thousand satoshis times the base-ten logarithm of half a bitcoin less than the amount, measured in satoshis.

Let's hope that counterparty gives a profitable minsize...

@raedah
Copy link
Contributor Author

raedah commented Nov 29, 2015

I think that makes a lot sense. Make AbsoluteFee() RelativeFee() TxContribution() the simple beginnings of an extensible scripting language. When participants handshake, they can communicate what functions they support.

@raedah
Copy link
Contributor Author

raedah commented Dec 4, 2015

Id like to see txfee with the ability to be set relative as well. Perhaps relative to the cjfee being earned. So, txfee contribution is 10% of the cjfee being earned with a min of 10 satosh and a max of 5000 satosh.

Also possible is a relorder cjfee that is relative to the amount. So cjfee has a base of 0.005% with +0.001% for every 50 btc in size of the order.

@raedah
Copy link
Contributor Author

raedah commented Dec 8, 2015

Another function could be JoinParticipants() which would define requirements for the number of participants to be in a join, and possibly set different fees for different cases. ex: provide a cjfee discount when participating in transactions with more join participants.

@raedah
Copy link
Contributor Author

raedah commented Jan 1, 2016

Proposed, txfee contribution can go away. Taker decides miner fee for the transaction, and cost is already accounted for by the cjfee. Txfee is currently needed for relative orders since txfee is per transaction, but once once we have a single order type that supports both a per transaction fee and a % of size fee, then per transaction cost is always available.

@adlai
Copy link
Contributor

adlai commented Feb 4, 2016

@raedah see discussion on #120

@chris-belcher
Copy link
Collaborator

chris-belcher commented Jul 11, 2016

This could be useful if only so that there's no need for two order types. (relorder and absorder today)

The coinjoin fee can be A*amount + B, and the order announces the values A and B.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants