Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for creating a meeting using a default password #281

Closed
mxswd opened this issue Apr 8, 2023 · 9 comments · Fixed by #280
Closed

Allow for creating a meeting using a default password #281

mxswd opened this issue Apr 8, 2023 · 9 comments · Fixed by #280
Assignees
Labels
Breaking Change This change causes backward compatibility issue(s)
Milestone

Comments

@mxswd
Copy link
Contributor

mxswd commented Apr 8, 2023

When creating a meeting there are 3 security options, and you must pick at least one.

If you use the API to create a meeting these security options don't match the API 1-to-1, but rather you need to combine certain options to trick zoom into working the way you want.

It seems if you want:

  1. To allow participants to join before the host
  2. Disable waiting room
  3. Don't require authentication

Screenshot 2023-04-08 at 11 32 02 AM

You need to send a request with:

  1. join_before_host set to true.
  2. jbh_time set to an integer.
  3. waiting_room set to false.
  4. A password set.

Admin's have an array of options to configure meeting password strength so the API provides a convenient default_password option so you don't need to lookup the account password options and generate one that matches those rules yourself.

Screenshot 2023-04-08 at 11 37 11 AM

I'm basing this off the light amount of documentation on:

https://developers.zoom.us/docs/api/rest/reference/zoom-api/methods/#operation/meetingCreate

And significant testing on my side.

@Jericho Jericho assigned Jericho and mxswd and unassigned Jericho Apr 8, 2023
@Jericho Jericho added the Breaking Change This change causes backward compatibility issue(s) label Apr 8, 2023
@Jericho
Copy link
Owner

Jericho commented Apr 8, 2023

Makes a lot of sense to enable developers to request the password to be auto-generated.

Also, I'm intrigued by this comment you made:

When creating a meeting there are 3 security options, and you must pick at least one.

What happens if a developer attempts to create a meeting but does not pick any of the options? Do they get a clear error message from Zoom? If not, is this something we should validate in ZoomNet? FYI: my attitude regarding validation has been to avoid it as much as possible because who knows if/when the validation rules in the Zoom API change and I would hate to enforce some validation rule that makes sense today but may or may not still be valid in the future. Having said that, I'm willing to make exceptions if there are situations that cause confusion, unclear error messages, unexpected outcome, etc.

@Jericho Jericho added this to the 0.60.0 milestone Apr 8, 2023
@mxswd
Copy link
Contributor Author

mxswd commented Apr 8, 2023

I did some testing it seems if you try to pick none of the options it will force the waiting room option. For example if you send this request:

await zoomClient.Meetings.CreateScheduledMeetingAsync(userId, calendarEvent.Summary, calendarEvent.Description, calendarEvent.DtStart.ToTimeZone("AUS Eastern Standard Time").Value, calendarEvent.Duration.Minutes, ZoomNet.Models.TimeZones.Australia_Sydney, settings: new ZoomNet.Models.MeetingSettings {
    JoinBeforeHost = true,
    WaitingRoom = false,
    ApprovalType = ZoomNet.Models.ApprovalType.None,
    UsePmi = false
});

It ignores the WaitingRoom = false and you get a meeting with waiting room enabled. And if you add the default_password flag to this API call you get a meeting with WaitingRoom disabled and passcode enabled.

@Jericho Jericho linked a pull request Apr 13, 2023 that will close this issue
@Jericho Jericho modified the milestones: 0.60.0, 0.61.0 Apr 15, 2023
@Jericho Jericho modified the milestones: 0.61.0, 0.62.0 May 1, 2023
@Jericho Jericho removed this from the 0.62.0 milestone May 12, 2023
@LucasMetal
Copy link

Just passing by.... I noticed I have recently read something about this topic here:
https://support.zoom.com/hc/en/article?id=zm_kb&sysparm_article=KB0059862

In the first paragraphs it explains the behavior that @mxswd mentions.

Hope this helps ;)

@Jericho
Copy link
Owner

Jericho commented Oct 23, 2024

Thanks for the link. Sadly the original contributor never completed the PR.

@LucasMetal would this functionality be useful to you?

@LucasMetal
Copy link

No, I don't need it (at least for now).
I was checking something else, and just thought the link could be useful.

Keep up the good work!!
Thanks!

@Jericho Jericho added this to the 0.83.0 milestone Oct 28, 2024
@Jericho
Copy link
Owner

Jericho commented Oct 28, 2024

Note to those interested in this new parameter: it appears that a custom password you specify when creating a meeting takes precedence. This means that setting the new generatePassword to true is not sufficient to generate a password, you must also set the password parameter to null.

Also note that when you set this new parameter to true, Zoom will EITHER generate a random password OR use the default password configured in your user's security settings. It's not 100% clear to me what determines which of the two actions is taken.

@Jericho
Copy link
Owner

Jericho commented Nov 2, 2024

🎉 This issue has been resolved in version 0.83.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@mxswd
Copy link
Contributor Author

mxswd commented Nov 3, 2024

Awesome, thanks a lot for making the change. It will help a lot.

@Jericho
Copy link
Owner

Jericho commented Nov 3, 2024

You're welcome. I raised #374 to warn developers about the breaking changes and guide them to resolution. Hopefully my instructions are clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change causes backward compatibility issue(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants