Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phlay not found when using "Send to code review" in Firefox Git #421

Open
rugk opened this issue Jan 24, 2019 · 1 comment
Open

Phlay not found when using "Send to code review" in Firefox Git #421

rugk opened this issue Jan 24, 2019 · 1 comment

Comments

@rugk
Copy link

rugk commented Jan 24, 2019

STR:
grafik

You get an error:

bash: line 1: phlay: command not found


Process exited with code: 127

So either include that tool (whatever it does) or remove that entry from the IDE…

@jankeromnes jankeromnes changed the title Phlay not included in Firefox Git container Phlay not found when using "Send to code review" in Firefox Git Jan 25, 2019
@jankeromnes
Copy link
Member

@rugk wow, thanks, I was able to reproduce this issue.

It's strange, because we do install phlay in Firefox (git) containers:

https://github.com/JanitorTechnology/dockerfiles/blob/58e2300fd137a157b6c429a9190ea77ddd8ebfda/firefox/firefox-git.dockerfile#L38-L41

And when you manually run phlay in the regular Terminal, it works.

However, when you run it via the menu entry, it seems that ~/.bashrc is not being run. I think we'll want to use a hard-coded PATH, e.g.

Send to code review (/home/user/.phlay/phlay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants