Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Preview configuration #10

Open
2 tasks
jankeromnes opened this issue Dec 8, 2017 · 0 comments
Open
2 tasks

Improve Preview configuration #10

jankeromnes opened this issue Dec 8, 2017 · 0 comments

Comments

@jankeromnes
Copy link
Member

jankeromnes commented Dec 8, 2017

  • For some ports like 8088, we need to open a specific path (not just / or /index.html) like for example /vnc.html (or /ide.html for 8089). I believe we could fix this by supporting a path attribute in our port specification:
"ports": {
  "8088": {
    "label": "VNC",
    "proxy": "https",
    "preview": true,
    "path": "/vnc.html"
  }
}

(Or maybe we could somehow merge preview and path, e.g. "preview": "/vnc.html"?)

  • Additionally, some Run configurations have an attribute like "openPort": "8088":
{
  "Run (dev)": {
    "cmd": "./mach run --dev",
    "openPort": "8088"
  }
}

This attribute doesn't do anything yet, but maybe we could script Cloud9 to open the right preview when this Run configuration is triggered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant