Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postgres and redis port mapping from docker-compose.yml #805

Open
Flightkick opened this issue Dec 12, 2023 · 2 comments
Open

Remove postgres and redis port mapping from docker-compose.yml #805

Flightkick opened this issue Dec 12, 2023 · 2 comments

Comments

@Flightkick
Copy link

The docker-compose.yml example exposes the ports for redis and postgres publicly.
Declaring the port mapping is not necessary when containers reside in the same network so they can safely be removed.

@JaneJeon
Copy link
Owner

Just for confirmation, you're talking about the one in deploy/ folder and not the top-level compose.yaml (which is for development) right?

In that case, yeah, good call. Someone else made it, I accepted it without too much scrutiny but it 100% tracks. Mind making a quick PR?

@Flightkick
Copy link
Author

That is correct! FYI You could also lock down the development one to bind to the loopback adapter instead of the public interface by specifying it in the mapping, e.g.: - "127.0.0.1:5432:5432"

I'm not using the project yet and rather not go through the fork/PR process for such a small one-off change. Feel free to pick it up whenever you're touching the code anyway. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants