Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Ask: New Tab Function #3

Open
spearkkk opened this issue Aug 24, 2024 · 4 comments
Open

Feature Ask: New Tab Function #3

spearkkk opened this issue Aug 24, 2024 · 4 comments

Comments

@spearkkk
Copy link

I'd really thanks for your nice tool.
I used this studio to create my color theme for Chrome.
Of cource, I change some value after this studio because there is no function to customize here.

So, could you consider adding new tab function for this studio?
It would be more cool :D

Thank you.

@JamsheedMistri
Copy link
Owner

Hi there, thanks for your suggestion! You mentioned that you did additional customization after the theme was generated. Do you mean manually editing the manifest file? If so, can you please share what syntax in particular was updated? If it was a small/easy change, then I'd be happy to look into adding it. But when I made this tool, I was sure to include every possible value that was available to be customized in manifest v2. Let me know if I missed something.

@spearkkk
Copy link
Author

....
  "ntp_background": [0, 59, 70],
  "ntp_text": [255, 204, 102]
...

I added some above properties.
And I refered this link.

ntp_background is to set background color for new tab page.
ntp_text is to set text color as you can guess.

Thank you!

@JamsheedMistri
Copy link
Owner

Hi @spearkkk, thanks for this information. I do remember now that these were parameters that have existed since I built the application with manifest v2. However, I intentionally decided to exclude these parameters from the manifest because, when omitted, the new tab page colors would automatically be generated using an accent color of the tab background colors, which ended up looking very aesthetically pleasing.

However, since you are requesting this feature to be added, clearly there is a desire for it, so I'd be happy to look into this at a future date. Please be warned that I have very little free time, so this likely won't get done for quite some time. I noticed you have some open source contribution history, so if you'd like to make a pull request, contributions are welcome :)

@spearkkk
Copy link
Author

spearkkk commented Sep 7, 2024

@JamsheedMistri
Hi, Okay thanks anyway !
It is really useful for me.
I will send PR if i have time to do it

Have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants