Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PacketSet to register ActionStreamPackets with info about their contents #441

Open
Jameskmonger opened this issue Jul 22, 2021 · 0 comments
Labels
dev-erg refactoring etc @shoki shoki kit

Comments

@Jameskmonger
Copy link
Owner

Currently you have to do this in the PacketSet:

sendGameEvents: ActionStream.ActionStreamPacket;

And then separately you have to bind it up like this:

		call(
			ActionStream.incomingSaga<GameServerToClient.PacketSet, "sendGameEvents">(
				registry,
				"sendGameEvents",
				GameEvents.GameEventActionTypesArray
			)
		),

for incoming, as well as another for outgoing. And repeat for every ActionStreamPacket you use

It would be really nice if this could be automated in some way, even just some kind of incomingStreams(packetSet) or something

@Jameskmonger Jameskmonger added dev-erg refactoring etc @shoki shoki kit labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-erg refactoring etc @shoki shoki kit
Projects
None yet
Development

No branches or pull requests

1 participant