Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate animation layer #289

Open
Jameskmonger opened this issue Jul 27, 2020 · 0 comments
Open

Separate animation layer #289

Jameskmonger opened this issue Jul 27, 2020 · 0 comments
Labels
@battle creatures battling eachother on the board @board the board and the bench dev-erg refactoring etc

Comments

@Jameskmonger
Copy link
Owner

Add a pieceAnimations entry to BoardState and update this separately

This part in takePieceTurn is not great

        const attacker: PieceModel = {
            ...board.pieces[pieceId],
            attacking: null,
            hit: null,
        };

Rather than applying animation classes directly to the piece components, create separate PieceAnimationWrapper components and use those to select animations from stores

@Jameskmonger Jameskmonger added @battle creatures battling eachother on the board dev-erg refactoring etc @board the board and the bench labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@battle creatures battling eachother on the board @board the board and the bench dev-erg refactoring etc
Projects
None yet
Development

No branches or pull requests

1 participant