Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the function names in listed files #52

Closed
Seyi007 opened this issue Oct 6, 2024 · 3 comments · Fixed by #87
Closed

Replace the function names in listed files #52

Seyi007 opened this issue Oct 6, 2024 · 3 comments · Fixed by #87
Assignees
Labels
enhancement New feature or request outreachy for outreachy interns

Comments

@Seyi007
Copy link
Collaborator

Seyi007 commented Oct 6, 2024

          [R/pre-msa-tree.R](https://github.com/JRaviLab/MolEvolvR/blob/main/R/pre-msa-tree.R)

R/CHANGED-pre-msa-tree.R

Original Modified User Facing
RepresentativeAccNums createRepresentativeAccessionNumbers
write.MsaAAMultipleAlignment writeMsaAaMultipleAlignment2FA
get_accnums_from_fasta_file getAccessionNumbersFromFA

R/reverse_operons.R

Original Modified User Facing
reveql straightenOperonSeq
reverse_operon reverseOperonSeq

Originally posted by @the-mayer in #7 (comment)

All updates should follow this format:

Original Modified User Facing
original_function newFunction

NOTE: Before beginning to work on a particular file, please check to see that @jananiravi has given the 👍 on the comment.

Please follow the contributing guidelines and create a new branch containing your changes. Commit your work, and submit a PR when ready for review.

Additionally, use the search in all files functionality in VS code, Rstudio, or any other text editor, and list all files the function is being called or used to be updated later.

@Seyi007 Seyi007 added enhancement New feature or request outreachy for outreachy interns labels Oct 6, 2024
@jananiravi
Copy link
Member

These need to be renamed from the original list #7, as well. E.g., AccessionNumbers to AccNum. MSA -- all caps, etc.

@teddyCodex teddyCodex assigned teddyCodex and unassigned jananiravi and the-mayer Oct 8, 2024
@teddyCodex
Copy link
Collaborator

These need to be renamed from the original list #7, as well. E.g., AccessionNumbers to AccNum. MSA -- all caps, etc.

Hi @jananiravi this name writeMSAAAMultipleAlignment2FA doesn't seem very intuitive especially cos of the 'AAA'
Any suggestions for a better name?
cc @the-mayer
does writeMSA_AAMultipleAlignment2FA work?

@jananiravi
Copy link
Member

writeMSA_AA2FA should, in fact, suffice, I think. [could you double-check to see that's what the function does?]
cc: @epbrenner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request outreachy for outreachy interns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants