Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-CMD Check : selectLongestDuplicate, plotEstimatedWallTimes, removeTails, condenseRepeatedDomains, plotStackedLineage #114

Closed
10 tasks
Klangina opened this issue Oct 28, 2024 · 2 comments · Fixed by #115

Comments

@Klangina
Copy link
Contributor

  • pick_longer_duplicate selectLongestDuplicate: no visible binding for global variable ‘AccNum’
  • pick_longer_duplicate selectLongestDuplicate: no visible binding for global variable ‘row.orig’
  • plot_estimated_walltimes plotEstimatedWallTimes: get_powerset : : no visible global function definition for ‘combn’
  • plot_estimated_walltimes plotEstimatedWallTimes: no visible binding for global variable ‘n_inputs’
  • plot_estimated_walltimes plotEstimatedWallTimes: no visible binding for global variable ‘est_walltime’
  • plot_estimated_walltimes plotEstimatedWallTimes: no visible binding for global variable ‘advanced_opts’
  • remove_tails removeTails: no visible binding for global variable ‘domains_keep’
  • repeat2s condenseRepeatedDomains : no visible binding for global variable ‘.’
  • stacked_lin_plot plotStackedLineage: no visible binding for global variable ‘cpcols’
  • stacked_lin_plot plotStackedLineage : no visible global function definition for ‘unit’

Originally posted by @the-mayer in #4 (comment)

@Klangina
Copy link
Contributor Author

Fixed all the warnings except:

removeTails: no visible binding for global variable ‘domains_keep’
@jananiravi @the-mayer : Need the logic for extracting domains_keep from prot, kindly guide.

Klangina added a commit to Klangina/MolEvolvR that referenced this issue Oct 28, 2024
Adding a blank commit to link PR to the issue
@the-mayer the-mayer linked a pull request Oct 30, 2024 that will close this issue
11 tasks
@the-mayer
Copy link
Collaborator

As the keep_domains param defaults to FALSE, it seems like this bit of code rarely (if ever) gets evaluated. Regardless, this is a good find! I'm going to convert your comment to another issue, while merging the other changes in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants