Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line 208 in abcd.py gives NAN values #52

Open
zarrarkhan opened this issue Aug 17, 2020 · 0 comments
Open

Line 208 in abcd.py gives NAN values #52

zarrarkhan opened this issue Aug 17, 2020 · 0 comments

Comments

@zarrarkhan
Copy link
Collaborator

Reported by Guta W Abeshu in email to Mohamad on Saturday, August 15, 2020:

"I found a numerical issue that results in NAN in estimated runoff magnitudes in the recent version of Xanthos. This issue is only noticeable beyond 1985 in many basins.

Below here is the equation used for ET opportunity computation (Line 208, on the GitHub file abcd.py). The NAN values were detected when the term under the square root is < 0. In terms of magnitude, the values under square root during these times were found to be in the order of 1e-10. So, merely rounding the decimal places reduces them to zero and solves the problem. It is a small issue, but the NAN values generated here propagates to flow routing, causing additional problems. "

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant