Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INSTALL]: GitHub CLI #1105

Open
14 tasks
TerrenceMcGuinness-NOAA opened this issue May 6, 2024 · 9 comments · May be fixed by #1270
Open
14 tasks

[INSTALL]: GitHub CLI #1105

TerrenceMcGuinness-NOAA opened this issue May 6, 2024 · 9 comments · May be fixed by #1270
Assignees
@eap @RatkoVasic-NOAA
Labels
NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center

Comments

@TerrenceMcGuinness-NOAA
Copy link

Package name

gh

Package version/tag

v2.28.0

Build options

None

Installation timeframe

Only needed on all supported RDHPCS systems. Already in lmod on WCOSS2.

Other information

No response

WCOSS2

  • Check this box if and only if your package should be installed on WCOSS2 Cactus and Dogwood (all spack-stack packages will be installed on Acorn). If not, you may disregard the rest of the items below and submit this request.

WCOSS2: General questions

No response

WCOSS2: Installation and testing

No response

WCOSS2: Technical & security review list

  • The code is mature, stable, and production ready
  • The code is does not and cannot use the internet, and does not contain URLs (http, https, ftp, etc.) except in comments
  • The package does not contain prebuilt binary files that have not been approved by NCO security review
  • The code has no publicly disclosed cybersecurity vulnerabilities and exposures (search https://cve.mitre.org/cve/)
  • The code is not prohibited by DHS, DOC, NOAA, or NWS
  • The code comes from a trusted source. Trusted sources include other NWS, NOAA, or DOC, agencies, or other Federal agencies that operate at a FISMA high or equivalent level. Additionally, trusted sources could be third-party agencies through which there is an existing SLA on file (such as RedHat).
  • The code is actively maintained and supported (it continues to get updates, patches, etc.)
  • The code is not maintained by a private entity operating in a foreign country (if it is, make a note below)
  • There is sufficient documentation to support maintenance
  • There are no known security vulnerabilities or weaknesses
  • Installing and running the code does not require privileged processes/users
  • There are no software dependencies that are unapproved or have security concerns (if there are, make a note below)
  • There are no concerns related to SA, SI, and SC NIST control families

WCOSS2: Additional comments

No response
@climbfuji climbfuji added NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center labels May 6, 2024
@mathomp4
Copy link
Collaborator

gh v2.49.2 is now in spack mainline. I'm planning a PR for gh 2.50.0 now.

@mathomp4 mathomp4 mentioned this issue Jun 11, 2024
Merged
@DavidHuber-NOAA DavidHuber-NOAA mentioned this issue Jul 15, 2024
Merged
7 tasks
@climbfuji
Copy link
Collaborator

global-workflow needs version 2.28 or something close

@eap
Copy link
Collaborator

eap commented Aug 6, 2024

@TerrenceMcGuinness-NOAA - I'm a little confused on this issue. GitHub CLI 2.28 is a bit over 2 years old and is missing quite a few features and bug-fixes in the current release. Can global-workflow be updated to use a more recent version of the CLI?

@aerorahul
Copy link

@climbfuji The latest version of gh-cli is fine in ss-1.8.0

@climbfuji
Copy link
Collaborator

Thanks @aerorahul! @eap do you want to go ahead and add a recent version of gh cli?

@eap eap linked a pull request Aug 23, 2024 that will close this issue
Open
3 tasks
@eap
Copy link
Collaborator

eap commented Sep 16, 2024

Adding an update to track status: the gh CLI requires golang which breaks intel platforms. This has been pushed to 1.9 pending fixes for go

@mathomp4
Copy link
Collaborator

Adding an update to track status: the gh CLI requires golang which breaks intel platforms. This has been pushed to 1.9 pending fixes for go

Query: How does golang break intel? I mean...I've built go programs on Intel chips before.

@climbfuji
Copy link
Collaborator

go doesn't build with anything else than gcc in spack, and on many systems go isn't available as an external package. We now have the functionality in place to tell spack(-stack) to always build go with gcc, regardless of what the principal compiler for the environment is. But this was too close for release/1.8.0 to be implemented and tested.

@mathomp4
Copy link
Collaborator

Ohhh. Intel the compiler! I've been thinking about chips too long. Makes more sense now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eap eap

@RatkoVasic-NOAA RatkoVasic-NOAA

Labels
NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center
Projects
spack-stack-1.9.0 (2024 Q4)
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add github CLI to global-workflow-env eap/spack-stack
9 participants
@mathomp4 @climbfuji @aerorahul @eap @RatkoVasic-NOAA @jkbk2004 @Hang-Lei-NOAA @TerrenceMcGuinness-NOAA @AlexanderRichert-NOAA