Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaintTree MaximumBottom not remove BottomSpace #1281

Open
chinawsb opened this issue Dec 3, 2024 · 3 comments
Open

PaintTree MaximumBottom not remove BottomSpace #1281

chinawsb opened this issue Dec 3, 2024 · 3 comments
Labels
Repro Steps Missing A smple project is needed to reprodcue and analyze the issue. See our guidelines for opening issues!

Comments

@chinawsb
Copy link

chinawsb commented Dec 3, 2024

I use BottomSpace to manual draw footer, but in VirtualTrees.BaseTree.PaintTree:

MaximumBottom := Target.Y + (Window.Bottom - Window.Top);

I think this need remove BottomSpace like this:
MaximumBottom := Target.Y + (Window.Bottom - Window.Top-BottomSpace);

@chinawsb
Copy link
Author

chinawsb commented Dec 3, 2024

More fixup in VirtualTrees.BaseTree.TBaseVirtualTree.DoSetOffsetXY avoid mouse wheel flick
if (toShowBackground in FOptions.PaintOptions) and Assigned(FBackground.Graphic) then
->
if (BottomSpace>0) or ((toShowBackground in FOptions.PaintOptions) and Assigned(FBackground.Graphic)) then

@joachimmarder
Copy link
Contributor

Please respect our guidelines on the project homepage for submitting bugs. Please include your version of Virtual TreeView and Delphi, and attach a sample compiling project as ZIP to your report that allows to replicate the problem. If only small changes are required, a description is sufficient how a demo projects needs to be changed in order to replicate the bug. If you already have a solution, please supply a patch file.

In my test the BottomSpace was respected correctly.

@joachimmarder joachimmarder added the Repro Steps Missing A smple project is needed to reprodcue and analyze the issue. See our guidelines for opening issues! label Dec 7, 2024
@chinawsb
Copy link
Author

chinawsb commented Jan 4, 2025

This bug in version 7.6,I not test it in 8.x.

If not add BottomSpace,vertscrollbar will be make last row override by owner draw footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repro Steps Missing A smple project is needed to reprodcue and analyze the issue. See our guidelines for opening issues!
Projects
None yet
Development

No branches or pull requests

2 participants