Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typed=True or False works the other way around #20

Open
wbijster opened this issue Mar 30, 2021 · 0 comments
Open

typed=True or False works the other way around #20

wbijster opened this issue Mar 30, 2021 · 0 comments

Comments

@wbijster
Copy link

wbijster commented Mar 30, 2021

When I pass typed = True, the UntypedDataSet is downloaded and the other way around.

E.g.

cbsodata.get_data(tableid, dir='D:/jsondata/', typed=False)

returns the TypedDataSet.

Probably this code

# Download only the typed or untyped data

typed_or_not_str = "TypedDataSet" if typed else "UntypedDataSet"
metadata_table_names.remove(typed_or_not_str)

should be like this?:

typed_or_not_str = "UntypedDataSet" if typed else "TypedDataSet"
metadata_table_names.remove(typed_or_not_str)

in order to remove the option that was not chosen.

Kind regards, Wouter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant