Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT validation doesn't allow conflicting prefixed and non-prefixed claims #280

Closed
giarc3 opened this issue Sep 8, 2022 · 2 comments
Closed

JWT validation doesn't allow conflicting prefixed and non-prefixed claims #280

giarc3 opened this issue Sep 8, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@giarc3
Copy link
Member

giarc3 commented Sep 8, 2022

We currently use #[serde(alias = "...")] to allow claims like sid or http://ironcore/sid. If both are present, however, this will fail as serde sees them as duplicate keys.

We need to allow for both keys to be present during validation.
@giarc3 giarc3 added the bug Something isn't working label Sep 8, 2022
@giarc3 giarc3 mentioned this issue Sep 8, 2022
Closed
@digitalconnectionsau
Copy link

Hi,
Thank you for looking at this. If you need anything let me know.

@giarc3 giarc3 closed this as completed Sep 9, 2022
@BobWall23 BobWall23 mentioned this issue Sep 9, 2022
Closed
@skeet70
Copy link
Member

skeet70 commented Jul 18, 2023

This issue should've been fixed by IronCoreLabs/ironoxide#281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skeet70 @giarc3 @digitalconnectionsau