Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newtype wrappers for some low level network primitives #5039

Open
crocodile-dentist opened this issue Jan 15, 2025 · 0 comments
Open

Add newtype wrappers for some low level network primitives #5039

crocodile-dentist opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
maintenance Issues / PRs related to maintenance of any of the compoents.

Comments

@crocodile-dentist
Copy link
Contributor

We should reconsider the lack of newtype wrappers for things like DNS.Domain, Socket.PortNumber, Socket.SockAddr. If we have them, then:

we are in control of instances (it's not only about orphans, but also about stability);
it's easier to deal with when we'd switch to a different dns / network library.

Ad 1. It becomes a concern because of the ToJSON, and ToCBOR instances - but there's a trap with using instances for version codecs; at some point, one need extra newtype wrappers for new versions of encoding...;

Ad 2. isn't since the libraries we use are pretty stable - but who knows...

@crocodile-dentist crocodile-dentist added the maintenance Issues / PRs related to maintenance of any of the compoents. label Jan 15, 2025
@crocodile-dentist crocodile-dentist self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues / PRs related to maintenance of any of the compoents.
Projects
Status: No status
Development

No branches or pull requests

1 participant