-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Querable Network State #5046
Draft
coot
wants to merge
17
commits into
main
Choose a base branch
from
coot/public-network-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Querable Network State #5046
+3,560
−9,134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `Ouroboros.Network.Subscription` removed; * `Ouroboros.Network.ErrorPolicy` removed; * APIs removed from `Ouroboros.Network.Socket`: * `NetworkMutableState` & friends, * `withServerNode` and `withServerNode'`, * `NetworkServerTracers`, * `fromSnocket`, * `beginConnection` * `Ouroboros.Network.Server.Socket` replaced with a simpler server implementation in `Test.Ouroboros.Network.Server`. All tests & demos of `ouroboros-network-framework` update.
* Updated to compile with changes in the previous commit. * APIs removed from `Ouroboros.Network.{NodeToClient,NodeToNode}` modules: * NetworkServerTracers * NetworkMutableState APIs * withServer * ErrorPolicies * WithAddr * SuspendDecision * APIs removed from `Ouroboros.Network.NodeToNode` module: * IPSubscriptionTarget * NetworkIPSubscription * NetworkSubscriptionTracers * SubscriptionParams * DnsSubscriptionTarget * DnsSubscriptioinParams * NetworkDNSSubscriptionTracers * dnsSubscriptionWorker
Instead of writing `PublicPeerSelectionState` on each outbound governor loop iteration, provide a request-response API through a `StrictTMVar` which is monitored by the outbound governor. Note that `PublicPeerSelectionState` is a lazy record written through `StrictTMVar` via a lazy `Maybe` like type (and thus it is not evaluated to WHNF when written to the shared variable). It is up to the API user to evaluate what it needs.
It includes data from connection-manager and outbound/inbound governors.
…aring.Codec module The `Ouroboros.Network.RemoteAddress.Codec` seems like a better place for it, since its not only `peer-sharing` related.
coot
added
local-state-query
Issues / PRs related to local-state-query protocol
node-to-node
Issues and PRs relate to node-to-node protocols
outbound-governor
Issues / PRs related to outbound-governor
connection-manager
Issues / PRs related to connection-manager
inbound-governor
Issues / PRs related to inbound-governor
labels
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
connection-manager
Issues / PRs related to connection-manager
inbound-governor
Issues / PRs related to inbound-governor
local-state-query
Issues / PRs related to local-state-query protocol
node-to-client
Issues & PRs related to node-to-client protocols
node-to-node
Issues and PRs relate to node-to-node protocols
outbound-governor
Issues / PRs related to outbound-governor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Querable
node-to-node
protocol state throughnode-to-client
'sLocalStateQuery
mini-protocol.Exposes state from three components (only about
node-to-node
connections):Reflection on
node-to-client
is a possible future extension.Checklist
Quality
Maintenance
ouroboros-network
project.