Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fetching DReps images is throwing different errors in console #2546

Closed
bosko-m opened this issue Dec 17, 2024 · 0 comments · Fixed by #2548
Closed

🐛 Fetching DReps images is throwing different errors in console #2546

bosko-m opened this issue Dec 17, 2024 · 0 comments · Fixed by #2548
Assignees
@MSzalowski
Labels
🐛 Bug Something isn't working ♟️ Delegation Pillar
Milestone
🏛 Needed for Full...

Comments

@bosko-m
Copy link
Contributor

bosko-m commented Dec 17, 2024

Area

Delegation Pillar

Domain

gov.tools

Which wallet were you using?

No response

Context

While doing the manual exploratory testing of DRep directory on both production and preview, a lot of DRep image fetching related errors are being thrown and visible in the console.

Steps to reproduce

  1. Go to gov.tools or preview.gov.tools (with or without wallet connected)
  2. Turn on the javascript console
  3. Go to the DRep directory page

Actual behavior

A lot of DRep image fetching related errors are being thrown and visible in the console.

Expected behavior

There shouldnt be errors in regards to fetching DRep images in the console and those situations can probably be handled gracefull.
@bosko-m bosko-m added the 🐛 Bug Something isn't working label Dec 17, 2024
@bosko-m bosko-m moved this to To do in Govtool all Dec 17, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Dec 17, 2024
MSzalowski added a commit that referenced this issue Dec 17, 2024
@MSzalowski
fix(#2546): handle errors on fetching drep images
4ebd529
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Dec 17, 2024
@MSzalowski MSzalowski mentioned this issue Dec 17, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Dec 17, 2024 that will close this issue
fix(#2546): handle errors on fetching drep images #2548
Merged
5 tasks
MSzalowski added a commit that referenced this issue Dec 17, 2024
@MSzalowski
fix(#2546): handle errors on fetching drep images
b631d1a
MSzalowski added a commit that referenced this issue Dec 18, 2024
@MSzalowski
fix(#2546): handle errors on fetching drep images
1f31e34
MSzalowski added a commit that referenced this issue Dec 18, 2024
@MSzalowski
Merge pull request #2548 from IntersectMBO/fix/2546-fetching-dreps-im…
cd26b58 
…ages-is-throwing-different-errors-in-console

fix(#2546): handle errors on fetching drep images
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Dec 18, 2024
@bosko-m bosko-m mentioned this issue Dec 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
🐛 Bug Something isn't working ♟️ Delegation Pillar
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Archived in project
Milestone
🏛 Needed for Full governance / Mainnet
Development

Successfully merging a pull request may close this issue.

fix(#2546): handle errors on fetching drep images IntersectMBO/govtool
2 participants
@MSzalowski @bosko-m