Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF backend API axios instance #1575

Closed
teske00 opened this issue Jul 15, 2024 · 3 comments · Fixed by #1593
Closed

PDF backend API axios instance #1575

teske00 opened this issue Jul 15, 2024 · 3 comments · Fixed by #1593
Assignees

Comments

@teske00
Copy link

teske00 commented Jul 15, 2024

@MSzalowski @bosko-m @ValMBO @vpaunovic We need to pass to the PDF-UI the baseURL of the backend we use in the PDF-UI, currently we only have a dev environment (https://dev.api.pdf.gov.tools/). We have implemented locally that from govtool this endpoint is passed as a prop to the package. How does this solution look to you, if this is OK, this logic can already be implemented on govtool.
image

@teske00
Copy link
Author

teske00 commented Jul 15, 2024

@bosko-m Can you get information from the Bloxico team about which environments they have created for the PDF backend and what their URLs are?

@MSzalowski
Copy link
Contributor

We can provide another argument into the frontend docker file that would include the pdf API URL, and it needs to be provided on CI level as it also needs to be parsed into csp declarations to be working.

I'll provide appropriate PR with the ENV placeholder and tag you once its done @bosko-m

@MSzalowski
Copy link
Contributor

Pull request that covers that issue: #1593

@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Jul 18, 2024
@MSzalowski MSzalowski assigned MSzalowski and unassigned jdyczka Jul 18, 2024
jdyczka pushed a commit that referenced this issue Jul 18, 2024
MSzalowski added a commit that referenced this issue Jul 19, 2024
…from-the-env-variables

chore(#1575): Provide pdf api url from the env variables
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants