Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Add support for scripts in fromProposalProcedure #682

Closed
CarlosLopezDeLara opened this issue Nov 19, 2024 · 1 comment
Closed

[FR] - Add support for scripts in fromProposalProcedure #682

CarlosLopezDeLara opened this issue Nov 19, 2024 · 1 comment
Assignees

Comments

@CarlosLopezDeLara
Copy link
Contributor

Internal/External
Internal

Area
Governance

Describe the feature you'd like
Add support for scripts in fromProposalProcedure

fromProposalProcedure
  :: ShelleyBasedEra era
  -> Proposal era
  -> (L.Coin, Hash StakeKey, GovernanceAction era)
fromProposalProcedure sbe (Proposal pp) =
  shelleyBasedEraConstraints
    sbe
    ( Gov.pProcDeposit pp
    , case fromShelleyStakeCredential (L.raCredential (Gov.pProcReturnAddr pp)) of
        StakeCredentialByKey keyhash -> keyhash
        StakeCredentialByScript _scripthash ->
          error "fromProposalProcedure TODO: Conway era script reward addresses not yet supported"
    , fromGovernanceAction (Gov.pProcGovAction pp)
    )

Describe alternatives you've considered

Additional context / screenshots
This is required for completeness on Check if stake addresses in proposals are registered onchain #963

@smelc
Copy link
Contributor

smelc commented Dec 11, 2024

Fixed by #692 and IntersectMBO/cardano-cli#988

@smelc smelc closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants