Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with CIP-129 #284

Open
paweljakubas opened this issue Nov 27, 2024 · 2 comments · May be fixed by #288
Open

Comply with CIP-129 #284

paweljakubas opened this issue Nov 27, 2024 · 2 comments · May be fixed by #288
Assignees
@paweljakubas
Labels
haskell PR:ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG SEVERITY:MEDIUM Visible impact on a core functionality or some important performance degradation.

Comments

@paweljakubas
Copy link
Collaborator

Context

Curently we are supporting supports CIP-105
As CIP-129 was ratified we need to support it to be 100% compatible.

Decision

We are going to support CIP-129 fully.

Acceptance Criteria

Development

QA
@paweljakubas paweljakubas changed the title Conclude CIP- Conclude CIP-129 Nov 27, 2024
@paweljakubas paweljakubas changed the title Conclude CIP-129 Comply with CIP-129 Nov 27, 2024
@paweljakubas paweljakubas added PR:ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG SEVERITY:MEDIUM Visible impact on a core functionality or some important performance degradation. haskell labels Nov 28, 2024
@abailly
Copy link
Contributor

abailly commented Nov 28, 2024

Can you clarify in this issue what work is needed to make Cardano-address CIP-129 compliant?

@paweljakubas paweljakubas self-assigned this Dec 11, 2024
@paweljakubas
Copy link
Collaborator Author

Until now we had CIP-105 support implemented. CIP-0129 introduces byte appending to credential. Plus for drep script hash changes HRP prefix. Was drep_script, should be drep. Script hash vs key hash is differentiated via the added byte prefix. See CIP-0129 for details.

@paweljakubas paweljakubas linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paweljakubas paweljakubas

Labels
haskell PR:ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG SEVERITY:MEDIUM Visible impact on a core functionality or some important performance degradation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CIP-0129 support IntersectMBO/cardano-addresses
2 participants
@abailly @paweljakubas