-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add historical bulk changes to .git-blame-ignore-revs #2623
Comments
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
What would be good criteria for deciding which commits are bulk changes?
I guess any improvement is better than nothing, so even if we don't have an exhaustive list of criteria, what are some that we could reasonably do? |
STYLE commit type, affecting more than, let's say, 20 files? |
20 is maybe a low number. >100 files? Or maybe list commits by number of files affected, and then decide where to make the break? |
@dzenanz FYI: This is a useful script for identifying what to consider. #!/bin/bash
# Ensure the script is run in a Git repository
if ! git rev-parse --is-inside-work-tree &> /dev/null; then
echo "This is not a Git repository. Please navigate to a Git repository and try again."
exit 1
fi
# Loop through each commit and count the number of files changed
echo "Commit hash | Number of files changed"
echo "-------------------------------------"
git log --pretty=format:'%H' | while read commit_hash; do
num_files_changed=$(git diff-tree --no-commit-id --name-only -r "$commit_hash" | wc -l)
short_messages="$(git log -1 --oneline $commit_hash)"
echo "${short_messages}" |grep STYLE > /dev/null
if [ $? -eq 0 ] && [ $num_files_changed -gt 40 ]; then
echo -e "$commit_hash | $num_files_changed\t\t | $short_messages"
fi
done Commit hash | Number of files changed
-------------------------------------
e9af5c5e7745d59ccaa3ff2fd1eff4275ba427d0 | 395 | e9af5c5e77 STYLE: Reduce indentation else after return
e23a4dbd1d19c3fecd221a25e6f4c5825dc21e00 | 134 | e23a4dbd1d STYLE: Prefer local initialization
e1acaf5aa8d23c82594fd1a7cc9282b3c9786b84 | 982 | e1acaf5aa8 STYLE: Variable can be made constexpr
7b830c177488e4a0ef2a5c531e5835dffcb1d9c2 | 159 | 7b830c1774 STYLE: Prefer explicit const designation
2ca88c17004e1a093bfe8e5d21cc4c8227e42730 | 264 | 2ca88c1700 STYLE: Declaration and assignment can be joined
0b16b740df10c2bd498b07bfacffe282da7d789b | 151 | 0b16b740df STYLE: Use auto for variable type matches
375ee8c47a03792d0d3d5447c6b4c4be6b9f2fb4 | 2478 | 375ee8c47a STYLE: Prefer explicit const designation
814a24c84d3bf4bdc42ce8f07276997fabdb45d3 | 330 | 814a24c84d STYLE: Rigorous style conformance with clang-format 19.1.4
af9d1d28c02fdaf028653813b1f6686e3dbadf1b | 67 | af9d1d28c0 STYLE: Use conventional const notation
15d189f513ac63e3cafc77a58b39c8862ce6e844 | 98 | 15d189f513 STYLE: Replace CoordRepType with CoordinateType in ITK implementation
324eaf15d17dc1000df14aa9ba4f6e79d9ab1c15 | 57 | 324eaf15d1 STYLE: Replace CoordRepType with CoordinateType in tests
81267efac589bc7889c854c241d89c0dacaff1f7 | 276 | 81267efac5 STYLE: One declaration per line for readability
c1d9ff5b6de719aa256330b281fb79250ccf1859 | 98 | c1d9ff5b6d STYLE: Rename `TCoordRep` template parameters to `TCoordinate`
214b763c38bc3e58d3dc96d21b0a06c13ac93863 | 63 | 214b763c38 STYLE: prefer initialization to assignment.
18d683ec792bfa7b7a950f781cf9836a5ef64a4d | 52 | 18d683ec79 STYLE: Replace `T var; var = x` with `T var = x`
677b76192a6dcbf09375c7c1c19fa87ee8f59096 | 88 | 677b76192a STYLE: Replace T::Pointer with auto when initializing variables by New()
5b121f493f17d61c52c197b0c5df530fe01c4f8c | 44 | 5b121f493f STYLE: Replace `T var; var = x` with `T var = x` for arithmetic types
6cb6bf9823436fb9f8ec2eb4907fe7cbca314f27 | 47 | 6cb6bf9823 STYLE: Replace `T var; var.Fill(x)` with `auto var = MakeFilled<T>(x)`
7fd1e7341bddaedcbe1aa34d02f2e61c3555abea | 41 | 7fd1e7341b STYLE: Replace `Size var; var.Fill` with `auto var = Size::Filled`
d6c9eed8e1d718b4a4e7f3fdd76e825395a17f4a | 173 | d6c9eed8e1 (ndekker/Replace-Fill-with-itk-MakeFilled-in-tests) STYLE: Replace Fill calls with `auto var = itk::MakeFilled<T>` in tests
47335501a5a16c6eb42538a829d4b49229284dd6 | 79 | 47335501a5 (ndekker/Replace-Fill-0-with-initialization) STYLE: Replace `Fill(0)` on local variables with `{}` initialization
504d63b3dc435aae01ed35f352c5a589dac66924 | 43 | 504d63b3dc (ndekker/Replace-Fill-with-empty-initializer-or-Filled) STYLE: Replace `index.Fill` with `auto index = Index::Filled` in tests
be250b8fd39927de0d95a3b442c69ea7dd16926a | 204 | be250b8fd3 STYLE: Replace `size.Fill` with `auto size = Size::Filled` in tests
d36dfc65c7c3734872dc1bfedf16ce388e4ef33c | 69 | d36dfc65c7 STYLE: Replace Fill(0.) with {} initializer for local variables in tests
569a8b6fe9e3945c46e13f7b21e5512ebd61afaf | 226 | 569a8b6fe9 STYLE: Replace Fill(0) with {} initializer for local variables in tests
8a1498cd982378731baaf740367aeb93cd4a6867 | 52 | 8a1498cd98 (ndekker/Remove-const-from-string-return-type) STYLE: Remove `const` from `const std::string` return types
a2707a8bcbfc2f0ebc917386a23aa2ac6ffae943 | 51 | a2707a8bcb STYLE: Add `constexpr` to `if (Dimension ...)` statements
3282875e7cccc0e68c9c853a55ecf711f38a9ed6 | 93 | 3282875e7c (ndekker/Replace-SetSize-Index-in-tests) STYLE: Replace SetIndex/Size calls in tests with `region{ index, size }`
8f70ee7da1082a321e0efda3fb6a3c9d3b058558 | 119 | 8f70ee7da1 STYLE: Replace SetSize/Index calls in tests with `region{ index, size }`
b4f0bb8a6725e48c5f4c1e07fe19fff334a4be4a | 55 | b4f0bb8a67 STYLE: Replace "the the" with "the" in comments
e7a60b6ca764f1d19a69f20b61c311d700ff0105 | 55 | e7a60b6ca7 STYLE: Remove ` == true` from Boolean expressions
527843e9fc3e9eae598fd039602013d6818ebe51 | 74 | 527843e9fc (ndekker/AllocateZeroInitializedPixelBuffer) STYLE: Replace `Allocate(true)` calls with `AllocateInitialized()`
13ccff6af85522d77aa0e5e19fa929988a9de49d | 441 | 13ccff6af8 (ndekker/Replace-NumericTraits-ZeroValue) STYLE: Replace `NumericTraits<T>::ZeroValue()` with `T{}`
8b22004029a83862751689b8b878453efbbab567 | 65 | 8b22004029 STYLE: Replace ${git_protocol} with https
7d94ec1790ec0a59d7483645fd5f794a348c3da5 | 60 | 7d94ec1790 STYLE: Remote modules keep key-value on the same line
a8f034dbf9ed81d5e58b62e749e9e385c1a713be | 53 | a8f034dbf9 STYLE: Remove public defaulted default-constructor/destructor pairs
2c264ea2ef62e916c6ef947599ce659cc8fce5fe | 1603 | 2c264ea2ef STYLE: Replace itkTypeMacro calls with `itkOverrideGetNameOfClassMacro`
efa749515db840b54f7329b261d3ec4c3a575f83 | 1373 | efa749515d STYLE: Initial run of cmake-format
34a598a3a885aa7dfd8d2f3e3a65bc9b45d53f77 | 54 | 34a598a3a8 STYLE: Make PrintSelf implementation style consistent
c6fedbdb9ad501d879fba33c23cb088382d1dde5 | 60 | c6fedbdb9a STYLE: Remove initial `<<` insertion from `itkWarningMacro(<< "` calls
b52f423117bac0a0982c58960f7a80e1a25e6f2b | 112 | b52f423117 STYLE: Remove initial `<<` insertion from `itkDebugMacro(<< "` calls
1d0d43cc6d8a1e3fd23843d96c57b31e6b0461ff | 78 | 1d0d43cc6d STYLE: Remove initial `<<` from `itkGenericExceptionMacro(<< "` calls
89beb0447fc9d40dcfdd6ced49f81e1b1a1bc97e | 387 | 89beb0447f STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls
f7fa2693f619501142d6183d368afe03a5788ad2 | 121 | f7fa2693f6 STYLE: Use trailing return types in multi-line function declarations
1a914b71bd0e15a4ec687631924c2026b78726fb | 73 | 1a914b71bd STYLE: Use C++17 `_v` variable templates from `std` library type traits
42b0bfc0771652ade6a1055b00efbcf94376c20b | 127 | 42b0bfc077 STYLE: Replace `T var = NumericTraits<T>::ZeroValue()` with `T var{}`
5a60ed00adbc108e5c81bd2ddfbc988f28eaf722 | 48 | 5a60ed00ad STYLE: Remove unnecessary iterator `GoToBegin()` calls from Filtering
ef5cc8c495c5515d5533eae36a6900e6a63c7819 | 43 | ef5cc8c495 STYLE: Prefer C++11 zero initializer to ZeroValue
8f233d177abc68110e6ce3ffed21cb644d4ecd15 | 60 | 8f233d177a STYLE: Add in-class `{}` member initializers having trailing comments
2ec7cd1cf7f9b9afeff9cdfd88dbb0e463156d9d | 53 | 2ec7cd1cf7 STYLE: Fixed spelling errors in Modules/Core headers
5c97b7605e5bec4e9443b57314b50d4e090a845e | 168 | 5c97b7605e STYLE: Add in-class `{}` initializers to classes with virtual functions
c47ed1c1b3e26051de655f7ad03e975fae93b73b | 193 | c47ed1c1b3 STYLE: Make `PrintSelf` implementation style consistent
3ec88007fc06516ac5f49f00e0da07edb50db5e1 | 120 | 3ec88007fc (ndekker/Replace-quotes-around-escaped-single-characters) STYLE: Replace double quotes around escaped chars with single quotes
ea231d600298a16396a31742b5f26675e6c6334c | 325 | ea231d6002 STYLE: Replace double quotes around single characters with single quotes
e8773472ddc1cd3bb0a6b638e1cd70a6b4616160 | 211 | e8773472dd STYLE: Replace double quotes around a space character with single quotes
8d12282fd753fc6404d9c738cc20e8b61a1848cc | 95 | 8d12282fd7 STYLE: Add missing braces to the substatements of `if` statements
5e2c49f9eb80e78903ce8f9fd2b5952062653cab | 805 | 5e2c49f9eb STYLE: Add in-class `{}` member initializers to objects created by New()
2b1b5312fadf1a156882d06dc2e7c6b2a2290044 | 54 | 2b1b5312fa STYLE: Remove space between class and member names (follow-up)
|
100 of files changed seems like a reasonable cutoff. |
Please assign this to me. |
Issue InsightSoftwareConsortium#2623 This adds historical changes that - start their commit msg header with "STYLE" - and affect at least 1000 files
Issue #2623 This adds historical changes that - start their commit msg header with "STYLE" - and affect at least 1000 files
This file already exists and contains some bulk revisions to the codebase, but it may not have been systematically filled.
The text was updated successfully, but these errors were encountered: