Enable backend/netcontrol communication #30
+339
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecnama
added
enhancement
This was
linked to
issues
Oct 18, 2024
|
Besoin de review maintenant ou bien la PR n'est pas terminée ? |
|
Alors en théorie c'est terminé, mais les tests passent pas donc je les ai mal modifié j'imagine |
|
Fix tout est quand c'est bon, marque la PR comme "ready for review" |
SkytAsul
requested changes
Oct 19, 2024
Comment on lines
10
to
16
| class RequestError(Exception): | ||
| """ | ||
| Exception raised when a request to the netcontrol API fails. | ||
| """ | ||
| def __init__(self, message): | ||
| self.message = message | ||
| super().__init__(self.message) |
There was a problem hiding this comment.
Le système d'erreur n'est plus pareil. Il faut supprimer cette classe trop générique.
Comment on lines
63
to
64
| if response.json()["error"]: | ||
| raise RequestError(response.json()["error"]) |
There was a problem hiding this comment.
On utilisera les erreurs HTTP. Remplacer ces lignes par response.raise_for_status() qui lèvera automatiquement une HTTPError si jamais netcontrol a renvoyé une erreur 4xx ou 5xx.
KwikKill
force-pushed
the
upgrade-version
branch
from
cacc4df
to
f26d41b
Compare
|
Oula y'a un soucis de branches de base là |
added 6 commits
October 28, 2024 14:22
KwikKill
force-pushed
the
backend-netcontrol
branch
from
ff0ee2a
to
f71f477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the backend to send requests to the netcontrol API via http.
Checklist