QueryIterator should not panic on error

[alespour]

Specifications

• Package Version: 0.6.0
• InfluxDB Version: Cloud

Code sample to reproduce problem

When result contains unsupported data type, the following calls may cause panic.

ok := iterator.Next()
// or
pv := iterator.AsPoints()

influxdb3-go/influxdb3/query_iterator.go

Line 88 in 94c8385

panic(err)

influxdb3-go/influxdb3/query_iterator.go

Line 108 in 94c8385

panic(err)

Expected behavior

Next() and AsPoints() should not panic, but somehow return error.

Next methods could be changed according to these iterator guidelines and AsPoints similarly. ie

func (i *QueryIterator) Next() (map[string]interface{}, error) // how about adding a new type (or alias) for the value?
func (i *QueryIterator) AsPoints() (*PointValues, error)

This renders Value method useless, btw.

So perhaps adding a new iterator type designed according to the guidelines, and deprecating the existing one would be a better solution.

Actual behavior

panic may occur

Additional info

No response

[NguyenHoangSon96]

Hi @alespour 😊
I will take care of this ticket, but I have a question
func (i *QueryIterator) Next() (map[string]interface{}, error) // how about adding a new type (or alias) for the value?
It already has PointValues to prepresent a row. So... Can you clarify this?

[alespour]

Hi @NguyenHoangSon96 I missed that there already is such a type, the comment can be ignored then. Thanks :)