Bugfix: Align Radio-Button, Checkbox and Switch to web standards #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfafffabian-ifx
force-pushed
the
1479-radio-button-integrate-input-element
branch
from
42abf6d
to
ce93639
Compare
|
|
--STORYBOOK-PREVIEW--
|
pfafffabian-ifx
force-pushed
the
1479-radio-button-integrate-input-element
branch
from
ce93639
to
c532f13
Compare
…252dbed7b76a9deb06e705f2f.0
…ef0978634f92643181023cd37.0
|
--EXAMPLE-APPS-PREVIEW--
|
…d0251e1d4e859d8ef3c8aceaf.0
…f1b1abe9496bd767a83758ec4.0
|
Added value prop to checkbox, radio-button and switch
…8c16c62d36613cf512c31633b.0
…533e97b8fba5387491d525bce.0
pfafffabian-ifx
force-pushed
the
1479-radio-button-integrate-input-element
branch
from
f23d96f
to
b6d348b
Compare
pfafffabian-ifx
force-pushed
the
1479-radio-button-integrate-input-element
branch
from
b6d348b
to
998bcfe
Compare
|
The checkbox doesnt have the "disabled" arg in the story anymore. Not sure why this got removed, but the checkbox should be "disable-able" |
@pfafffabian-ifx you renamed value to checked, as I could see. Fine with me, if this is in accordance with the web standard. But yes, @tishoyanchev is right, value is still used in the code as well. What do you mean by the select options not being submitted? |
I told Fabian to remove it from the snippet to avoid confusion because when the disabled attribute is present, even if set to true, the value attribute doesn't work, and no value is submitted. This might confuse users, so I told him to just remove it from the snippet. |
When you put the multi-select component inside a , and select multiple options, and then submit it, the options were not getting submitted, but his is already resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Related Issue
Closes #1479
Fixes #1476 for the Radio Button
📦 Published PR as canary version:
26.0.0--canary.1485.2bf616acdcc9d0d562598edde850bf390cf42094.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@26.0.0--canary.1485.2bf616acdcc9d0d562598edde850bf390cf42094.0 # or yarn add @infineon/infineon-design-system-stencil@26.0.0--canary.1485.2bf616acdcc9d0d562598edde850bf390cf42094.0