Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

A11y concerns and semantics #149

Open
binyamin opened this issue Dec 22, 2021 · 2 comments · May be fixed by #150
Open

A11y concerns and semantics #149

binyamin opened this issue Dec 22, 2021 · 2 comments · May be fixed by #150

Comments

@binyamin
Copy link

I have a couple concerns about the HTML. I'm gonna take some liberty, and put in a PR with a rewrite of the markup. Of course, I'll make sure it runs correctly first.

Partial List of Concerns

  1. sidebar element doesn't exist. Probably meant to be aside.
  2. <a> should be <button>, since it doesn't actually open a new URL. 1
  3. Right now, Every single heading element on the page is an <h3>. 2
    1. The heading-levels should be different, depending on the content. Like an outline.
    2. There should always be a top-level heading (h1).
  4. The title attribute is not ideal for screen-readers. 3

Footnotes

  1. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#onclick_events ↩

  2. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/heading_elements#usage_notes ↩

  3. https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#accessibility_concerns ↩
@binyamin binyamin linked a pull request Dec 22, 2021 that will close this issue
Draft
8 tasks
@Cambridgeport90
Copy link

I definitely support this one being visually impaired myself.

@marksuth
Copy link
Collaborator

This is awesome, thanks! I know how important accessibility is, and will be happy to implement your pull request, and I'll take a look through the code myself to see if I can spot any glaring issues as well.

Cheers,
Mark

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A11y concerns and semantics binyamin/indigenous-desktop
3 participants
@marksuth @Cambridgeport90 @binyamin