You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.
I have a couple concerns about the HTML. I'm gonna take some liberty, and put in a PR with a rewrite of the markup. Of course, I'll make sure it runs correctly first.
Partial List of Concerns
sidebar element doesn't exist. Probably meant to be aside.
<a> should be <button>, since it doesn't actually open a new URL. 1
Right now, Every single heading element on the page is an <h3>. 2
The heading-levels should be different, depending on the content. Like an outline.
There should always be a top-level heading (h1).
The title attribute is not ideal for screen-readers. 3
This is awesome, thanks! I know how important accessibility is, and will be happy to implement your pull request, and I'll take a look through the code myself to see if I can spot any glaring issues as well.
Cheers,
Mark
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have a couple concerns about the HTML. I'm gonna take some liberty, and put in a PR with a rewrite of the markup. Of course, I'll make sure it runs correctly first.
Partial List of Concerns
sidebar
element doesn't exist. Probably meant to beaside
.<a>
should be<button>
, since it doesn't actually open a new URL. 1<h3>
. 2h1
).title
attribute is not ideal for screen-readers. 3Footnotes
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#onclick_events ↩
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/heading_elements#usage_notes ↩
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#accessibility_concerns ↩
The text was updated successfully, but these errors were encountered: