Remote Paging Grid & HGrid: Refactoring with the new customers endpoint #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrustev
approved these changes
Nov 12, 2024
|
Added changes for |
MarielaTihova
changed the title
skrustev
requested changes
Jan 7, 2025
| primaryKey="customerId" | ||
| height="600px" | ||
| data={data} | ||
| isLoading={isLoading} |
There was a problem hiding this comment.
For some reason there's a problem with this method of setting isLoading. It is not set in time when setting the data and results in no scrollbar when initially the data is rendered. Setting the property manually seems to work fine
Here how it is atm:
| context.grid.data = data; | ||
| context.grid.isLoading = false; |
There was a problem hiding this comment.
This is disabling loading but there's nothing enabling the loading initially for the child grid thus resulting in loading indicator not rendered for child grids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #667
Once this PR is merged, changes in IgniteUI/igniteui-xplat-docs#1375 should be made accordingly as well