Grid Filtering & Query builder redundant extended icons registration #14604
Labels
📈 enhancement
grid: filter-ui
🆕 status: new
query-builder
status: inactive
Used to stale issues and pull requests
✅ status: resolved
Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Noticed while going over changes in #14598 that both the filtering service and Query Builder (possibly copied over) pull all icons from the Material extended Editors category and register them all:
igniteui-angular/projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts
Lines 320 to 323 in 0451f11
igniteui-angular/projects/igniteui-angular/src/lib/query-builder/query-builder.component.ts
Lines 1210 to 1213 in 0451f11
That's regardless if all icons are used and I'm fairly certain we're not using all - e.g. previous quarter (even though we could in the future), match, YTD, etc. Now that the icons in use are very clearly listed and documented, would be very nice if we can shake the excess of SVG's we register for no reason.
Also, since the filtering the UI and Query Builder use the same set of icons for filtering operands, it'd be lovely if this operation is bundled somewhere shared around those and reused for the Grid and Query builder components.
The text was updated successfully, but these errors were encountered: