Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Filtering & Query builder redundant extended icons registration #14604

Open
damyanpetev opened this issue Jul 31, 2024 · 3 comments · May be fixed by #14859
Open

Grid Filtering & Query builder redundant extended icons registration #14604

damyanpetev opened this issue Jul 31, 2024 · 3 comments · May be fixed by #14859
Assignees
Labels
📈 enhancement grid: filter-ui 🆕 status: new query-builder status: inactive Used to stale issues and pull requests ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@damyanpetev
Copy link
Member

Noticed while going over changes in #14598 that both the filtering service and Query Builder (possibly copied over) pull all icons from the Material extended Editors category and register them all:

public registerSVGIcons(): void {
const editorIcons = editor as any[];
editorIcons.forEach(icon => {
this.iconService.addSvgIconFromText(icon.name, icon.value, 'imx-icons');

const editorIcons = editor as any[];
editorIcons.forEach((icon) => {
this.iconService.addSvgIconFromText(icon.name, icon.value, 'imx-icons');

That's regardless if all icons are used and I'm fairly certain we're not using all - e.g. previous quarter (even though we could in the future), match, YTD, etc. Now that the icons in use are very clearly listed and documented, would be very nice if we can shake the excess of SVG's we register for no reason.

Also, since the filtering the UI and Query Builder use the same set of icons for filtering operands, it'd be lovely if this operation is bundled somewhere shared around those and reused for the Grid and Query builder components.

Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 30, 2024
@gedinakova gedinakova added 🛠️ status: in-development Issues and PRs with active development on them and removed status: inactive Used to stale issues and pull requests labels Sep 30, 2024
@teodosiah teodosiah added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Dec 1, 2024
@gedinakova gedinakova removed the status: inactive Used to stale issues and pull requests label Dec 2, 2024
Copy link

github-actions bot commented Feb 1, 2025

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 enhancement grid: filter-ui 🆕 status: new query-builder status: inactive Used to stale issues and pull requests ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
4 participants