Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission config/x509 is required to edit jobs #234

Open
moreamazingnick opened this issue Feb 14, 2024 · 2 comments
Open

Permission config/x509 is required to edit jobs #234

moreamazingnick opened this issue Feb 14, 2024 · 2 comments

Comments

@moreamazingnick
Copy link
Contributor

moreamazingnick commented Feb 14, 2024

Describe the bug

Currently the permission config/x509 is required to create / edit jobs, which can not be given explicitly it is only included in config/*

To Reproduce

$this->assertPermission('config/x509');

Expected behavior

More granular permissions for

  • jobs
  • snis

Your Environment

Include as many relevant details about the environment you experienced the problem in

  • Icinga Web 2 version and modules (System - About): 2.12.1
  • Module X509: 1.3.2
  • PHP version used (php --version): 8.2
@moreamazingnick moreamazingnick changed the title Permission config/x509 is required to list certificates Permission config/x509 is required to list jobs Feb 14, 2024
@moreamazingnick
Copy link
Contributor Author

what if we do it like

$this->hasPermission('config/x509') || $this->hasPermission('x509/config')

that would't break compatibility for older role settings but provide a configurable permission in the role config?

@moreamazingnick moreamazingnick changed the title Permission config/x509 is required to list jobs Permission config/x509 is required to edit jobs Feb 15, 2024
@moreamazingnick
Copy link
Contributor Author

It is actually even more easier let's just add:

$this->providePermission("config/x509","something meaningful");

to the configuration.php

moreamazingnick added a commit to RISE-GmbH/icingaweb2-module-x509 that referenced this issue May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant