Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different behavior for types = [Recovery] between User and Notification objects #10211

Open
julianbrost opened this issue Oct 31, 2024 · 0 comments · May be fixed by #10223
Open

Different behavior for types = [Recovery] between User and Notification objects #10211

julianbrost opened this issue Oct 31, 2024 · 0 comments · May be fixed by #10223
Assignees
@yhabteab
Labels
area/notifications Notification events bug Something isn't working ref/IP
Milestone
2.15.0

Comments

@julianbrost
Copy link
Contributor

One can configure types = [Recovery] in both User and Notification objects. For User objects, there is special handling for this scenario to send recovery notifications regardless of whether a problem notification was sent:

icinga2/lib/icinga/notification.cpp

Lines 431 to 439 in d894792

/* on recovery, check if user was notified before */
if (type == NotificationRecovery) {
if (!notifiedProblemUsers->Contains(userName) && (NotificationProblem & user->GetTypeFilter())) {
Log(LogNotice, "Notification")
<< "Notification object '" << notificationName << "': We did not notify user '" << userName
<< "' (Problem types enabled) for a problem before. Not sending Recovery notification.";
continue;
}
}

However, for Notification objects, there is no such handling and configuring such an object simply never notifies. It would probably be a good idea to make this do the same as for the User object.

ref/IP/56200
@julianbrost julianbrost added bug Something isn't working ref/IP labels Oct 31, 2024
@yhabteab yhabteab self-assigned this Nov 8, 2024
@yhabteab yhabteab added this to the 2.15.0 milestone Nov 8, 2024
@yhabteab yhabteab linked a pull request Nov 8, 2024 that will close this issue
Open
@yhabteab yhabteab added the area/notifications Notification events label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yhabteab yhabteab

Labels
area/notifications Notification events bug Something isn't working ref/IP
Projects
None yet
Milestone
2.15.0
Development

Successfully merging a pull request may close this issue.

Notification: Fix incorrectly dropped recovery & ACK notifications Icinga/icinga2
2 participants
@julianbrost @yhabteab