Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom TLS options for Webhook Channel #256

Open
martialblog opened this issue Jul 25, 2024 · 2 comments · May be fixed by #269
Open

Custom TLS options for Webhook Channel #256

martialblog opened this issue Jul 25, 2024 · 2 comments · May be fixed by #269
Assignees
@oxzi
Labels
enhancement New feature or request

Comments

@martialblog
Copy link
Member

Hoi,

the webhook channel could use some TLS options, what if I want to use my shiny custom CA!

Regards
@oxzi oxzi self-assigned this Jul 26, 2024
@oxzi oxzi added the enhancement New feature or request label Jul 26, 2024
@oxzi
Copy link
Member

oxzi commented Aug 1, 2024

There are lots of knobs to adjust for TLS. For starters, Go's tls.Config has lots to offer.

I guess, the most requested features would be:

  • Custom CA, as you have posted.
  • Insecure mode, because YoloOps

Furthermore, some users might wanna configure the TLS version or even the cipher suites. However, this would be a pain through the current UI.

@oxzi
Copy link
Member

oxzi commented Aug 1, 2024

Honestly, this feature request would be valid for all currently implemented channels. Both your local SMTP server and your company RocketChat might use a custom certificate.

oxzi added a commit that referenced this issue Aug 1, 2024
@oxzi
webhook: Basic TLS Configuration, Custom Headers
309bcc4 
This change allows some basic TLS related configuration changes:
- Fixed Certificate Common Name
- Custom CA
- Insecure Mode w/o any verification

The last setting brought me to an unexpected boolean representation in
the JSON configuration, requiring a custom boolean type. It was added to
pkg/plugin and its documentation.

In addition, support for arbitrary HTTP request headers was added. This
allows custom headers, even carrying values based on the
NotificationRequest.

Additionally, an unique User-Agent was assigned.

Closes #256.
@oxzi oxzi linked a pull request Aug 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxzi oxzi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webhook: Basic TLS Configuration, Custom Headers Icinga/icinga-notifications
2 participants
@martialblog @oxzi