Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback] Ability to add Traefik specific labels when installing apps #773

Open
anlek opened this issue Dec 20, 2022 · 12 comments
Open

[Feedback] Ability to add Traefik specific labels when installing apps #773

anlek opened this issue Dec 20, 2022 · 12 comments
Assignees
Labels
Milestone

Comments

@anlek
Copy link

anlek commented Dec 20, 2022

Description

I'd love to use Traefik to do proxy routings, however, the current version of CasaOS doesn't support me adding/editing labels. Any chance that's a feature that's coming?

Additional Information

 - OS: linux
 - CasaOS Version: 0.4.0
 - Disk Total: 27712 
 - Disk Used: 10471 
 - System Info: [Debian GNU/Linux 11   \l Bit:64 Mem:7803M Core:4 Linux CasaOS 5.10.0-18-amd64 #1 SMP Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux]
 - Remote Version: 0.4.0
 - Browser: Chrome 
 - Version: 108.0.0.0
@tigerinus
Copy link
Contributor

@anlek - We will be looking into this in future iteration.

Currently CasaOS depends on container labelling heavily, so exposing label editing is a bit risky. But we will see.

@tigerinus tigerinus assigned ETWang1991 and unassigned tigerinus Dec 22, 2022
@gzavadskiy
Copy link

Ability to add docker labels, its very impotent please add it

@tigerinus
Copy link
Contributor

It's such a shame that I haven't got to understand how Traefik works until recently... It's definitely a big plus to CasaOS.

Seriously looking into this...

@Jamyz
Copy link

Jamyz commented Jun 5, 2023

I need label to use WATCHTOWER_LABEL_ENABLE="true"

@tigerinus tigerinus changed the title [Feedback] Ability to add docker labels [Feedback] Ability to add Traefik specific labels when installing apps Jun 5, 2023
@tigerinus
Copy link
Contributor

tigerinus commented Jun 5, 2023

I need label to use WATCHTOWER_LABEL_ENABLE="true"

My bad this issue is meant to track labelling specific to Traefik.

While there is no UI to allow adding labels, you can export the compose file from your app as YAML, update the label property manually, and then go to terminal and run

casaos-cli app-management apply <appid> -f <path to the updated yaml file>

See https://docs.docker.com/compose/compose-file/deploy/#labels for details and examples

@ETWang1991 ETWang1991 removed their assignment Jun 28, 2023
@tigerinus tigerinus added the enhancement New feature or request label Jul 6, 2023
@tigerinus tigerinus added this to the vNext milestone Jul 6, 2023
@tigerinus tigerinus assigned ETWang1991 and unassigned tigerinus Jul 6, 2023
@tigerinus
Copy link
Contributor

At minimum, we need to allow user to edit LABEL for each app in the UI.

This feature needs to be designed and implemented.

@mr-manuel
Copy link

As a workaround you can install and use Portainer in the meanwhile to edit the labels, if you don't want to do it over command line.

@anlek
Copy link
Author

anlek commented Aug 24, 2023

You could filter your own labels out of the "edit/add" list

@kforeverisback
Copy link

@tigerinus Looked at the CasaOS-App repo and CasaOS-UI repo. As far as I can tell, most of the App there doesn't expose some sort of common LABELS (they do expose some, but most of them are default labels from docker-image). And the CasaOS-UI repo, it doesn't seem its adding any extra casa specific Label either.

Could you point me to some codeblocks where I can take a look to see how the labels are used?

@hischampion
Copy link

Agreed this would be extremely helpful! Seems easy to filter special Casa labels by prefix? Alternatively only allow editing of labels that were originally user created, if a DB exists to remember that info.

Forgive my ignorance, please.

@anlek
Copy link
Author

anlek commented Sep 21, 2024

Any updates on the ETA for this ticket?

@Chuckame
Copy link

Chuckame commented Oct 5, 2024

I am looking at moving out from cli oriented management, and this feature is for me a requirement to commit this migration.

I would propose another click-ful label edition:

Why not proposing some global configuration to set a default set of labels, env vars and more, where each param could be set as mandatory or not, with a meaningful name and description, default values based on the app name by example, and more.
And when you go to install/edit/update an app, it displays those pre-configured params in a form, where the default values are already filled, and you can't install the app unless you set the mandatory params.

This would finally support any proxy (not only traefik) and all the docker-aware stuff for auth, monitoring and much more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Future
Development

No branches or pull requests

9 participants