[GradedAxes] Simplify dual graded unit range slicing #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
changed the title
mtfishman
reviewed
Nov 14, 2024
|
Looks good, thanks! Nice to see this code get simplified.
I was picturing it might be used to preserve dual information in operations like: r = gradedrange([U1(0) => 2, U1(1) => 3])
a = BlockSparseArray{Float64}(r, dual(r))
axes(@view(a[Block(1, 1)])) # (LabelledUnitRange, LabelledUnitRangeDual)But to me that is a good use case for having a |
mtfishman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies
blockedunitrange_getindicesby callingnondual(a). It also add tests to check both axes and elements have been dualled.The last case with
indices::AbstractBlockVector{<:Block{1}}is slightly different as it outputs a vector ofLabelledIntegerwhile the other return vectors ofLabelledUnitRangeDual.As a side note, the important information about dual is in the axes of the
BlockVectorand not in its element. Therefore we may completely removeLabelledUnitRangeDual(and just take the element dual of aLabelledUnitRange) without affectingBlockSparseArray.