[BlockSparseArrays] Simplifications of blocks for blocksparse Adjoint and Transpose
#1580
+36
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
Nov 13, 2024
NDTensors/src/lib/SparseArrayInterface/src/abstractsparsearray/wrappedabstractsparsearray.jl
Outdated
Show resolved
Hide resolved
mtfishman
reviewed
Nov 13, 2024
NDTensors/src/lib/SparseArrayInterface/src/abstractsparsearray/wrappedabstractsparsearray.jl
Outdated
Show resolved
Hide resolved
59 tasks
lkdvos
force-pushed
the
ld-wrappedviews
branch
from
1a740f3
to
cd6f8ab
Compare
|
This should 🤞 now have all necessary imports and be based on the latest main |
mtfishman
reviewed
Nov 15, 2024
Comment on lines
+209
to
+215
| a = dev(BlockSparseArray{elt}([1], [1, 1])) | ||
| @allowscalar a[1, 2] = 1 | ||
| @test [@views(a[it]) for it in block_stored_indices(a)] isa Vector | ||
| ah = adjoint(a) | ||
| @test [@views(ah[it]) for it in block_stored_indices(ah)] isa Vector | ||
| at = transpose(a) | ||
| @test [@views(at[it]) for it in block_stored_indices(at)] isa Vector |
There was a problem hiding this comment.
Could you make these tests a bit more comprehensive, i.e. maybe set some blocks and then check they are set correctly, check the types of the blocks, etc.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excises
SparseTransposeBlocksandSparseAdjointBlocks, and replaces them with the equivalentadjoint(blocks(a))andtranspose(blocks(a)).This should not change any functionality, but reduces the complexity as the number of wrapper types decreases.