Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current RPM value with actual RPM calculation, which takes into account reduction due to gear and microstepping. #20

Open
NejcKle opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@NejcKle
Copy link
Collaborator

NejcKle commented Jan 29, 2025

The origial idea was to replace all instances of RPM values with re-calculated values. But I think a better approach is to keep current RAW RPM values as they are and add real calculated RPM values to all of the screens.

That way backwards compatibility is not broken. We will need to add a microstepping field to the calibration files, to ensure proper settings have been used when calculating real RPM.

In case current microstepping setting is different from the one in the file a clear warning should be displayed.

@NejcKle NejcKle self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant