diff --git a/dave_demos/README.md b/dave_demos/README.md index e2defb52..3173f226 100644 --- a/dave_demos/README.md +++ b/dave_demos/README.md @@ -13,7 +13,7 @@ To launch a Dave model directly from a Fuel URI, follow these steps: 2. Launch the model using the specified launch file: ```bash - ros2 launch dave_demos mossy_cinder_block.launch.py + ros2 launch dave_demos model_in_empty_world.launch.py model_name:='mossy_cinder_block' ``` This method simplifies the process by pulling the model directly from Fuel, ensuring you always have the latest version without needing to manage local files. @@ -47,7 +47,7 @@ If you prefer to use model files downloaded from Fuel, proceed as follows: 4. Launch the model using the provided launch file: ```bash - ros2 launch dave_demos nortek_dvl500_300_bare_model.launch.py + ros2 launch dave_demos model_in_empty_world.launch.py model_name:='nortek_dvl500_300' ``` This approach gives you more control over the models you use, allowing for offline use and customization. It's especially useful when working in environments with limited internet connectivity or when specific model versions are required. diff --git a/dave_demos/launch/model_in_empty_world.py b/dave_demos/launch/model_in_empty_world.launch.py old mode 100644 new mode 100755 similarity index 97% rename from dave_demos/launch/model_in_empty_world.py rename to dave_demos/launch/model_in_empty_world.launch.py index eb465043..fee6c278 --- a/dave_demos/launch/model_in_empty_world.py +++ b/dave_demos/launch/model_in_empty_world.launch.py @@ -2,9 +2,8 @@ from launch.actions import DeclareLaunchArgument, IncludeLaunchDescription from launch.substitutions import ( LaunchConfiguration, - PathJoinSubstitution, - TextSubstitution, -) + PathJoinSubstitution + ) from launch.launch_description_sources import PythonLaunchDescriptionSource from launch.conditions import IfCondition from launch_ros.substitutions import FindPackageShare diff --git a/dave_model_description/launch/upload_model.launch.py b/dave_model_description/launch/upload_model.launch.py old mode 100644 new mode 100755 index 3444df87..003af735 --- a/dave_model_description/launch/upload_model.launch.py +++ b/dave_model_description/launch/upload_model.launch.py @@ -1,5 +1,5 @@ from launch import LaunchDescription -from launch.actions import (DeclareLaunchArgument, RegisterEventHandler, LogInfo) +from launch.actions import DeclareLaunchArgument, RegisterEventHandler, LogInfo from launch.substitutions import LaunchConfiguration, PathJoinSubstitution from launch.conditions import IfCondition from launch_ros.substitutions import FindPackageShare @@ -46,11 +46,8 @@ def generate_launch_description(): event_handlers = [ RegisterEventHandler( - OnProcessExit( - target_action=gz_spawner, - on_exit=LogInfo(msg='Model Uploaded')) - ) + OnProcessExit(target_action=gz_spawner, on_exit=LogInfo(msg="Model Uploaded")) + ) ] - return LaunchDescription(args + nodes + event_handlers)