add dark mode arrow #268
Open
add dark mode arrow #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| leftArrowElement.classList.add('ui') | ||
| leftArrowElement.classList.add('icon') | ||
| leftArrowElement.classList.add('prev') | ||
| leftArrowElement.classList.add('icon_image') |
There was a problem hiding this comment.
Is the class icon_image already there? Was it that since it was not include the arrows used yo work bad?
There was a problem hiding this comment.
all the class names that I have added are present in the other dark mode arrows too. But the actual classes that are responsible for the dark mode feature are "icon" and "data-icon"
|
Just a small correction, dont know why it was working when I created the PR. Now it works fine. The video is of the slider component, whose dark mode arrow had to be rectified in the issue. simplescreenrecorder-2023-04-05_17.55.23.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
simplescreenrecorder-2023-02-19_01.23.07.mp4