Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GECKO missing imports? #56

Open
mcourtot opened this issue Mar 29, 2021 · 4 comments
Open

GECKO missing imports? #56

mcourtot opened this issue Mar 29, 2021 · 4 comments

Comments

@mcourtot
Copy link
Contributor

I didn't see the BFO or IAO import at https://raw.githubusercontent.com/IHCC-cohorts/GECKO/master/gecko.owl

@jamesaoverton
Copy link
Collaborator

It's best-practise to merge all imports when creating a release artifact (such as gecko.owl), so that there are no owl:import elements left, and the release artifact is self-contained. If you don't do that, you have two problems:

  1. every time someone opens gecko.owl they also need to connect to the Internet (or use a catalog file) to find the import files; network connections are never 100% reliable
  2. those import files may have changed, so now GECKO looks different than it did when released, potentially causing it to break

You can see that all the BFO and IAO terms we need (and all the other imported terms) have been merged into gecko.owl.

Imports are updated/refreshed at build-time according to recipes in the Makefile, for example:

https://github.com/IHCC-cohorts/GECKO/blob/master/Makefile#L110

See also:

https://github.com/INCATools/ontology-development-kit/blob/master/docs/ReleaseArtefacts.md#release-artefact-2-full-required

@mcourtot
Copy link
Contributor Author

hm - when I look at GECKO released version I do not see the BFO top-level though.

Screenshot 2021-03-30 at 11 04 40

@jamesaoverton
Copy link
Collaborator

If you want to see the top-level of BFO (entity, continuant, independent continuant, generically dependent continuant, occurrent, etc.), then we will put it in to GECKO. The current top-level of GECKO is based on the subset of BFO terms used in COB, which were selected to be intuitive to a broad audience with minimal jargon. We've used this same top-level structure since the first draft of GECKO. It will, of course, merge cleanly with any other ontology based on BFO.

@mcourtot
Copy link
Contributor Author

Thanks for the extra explanation. I had never noticed the top-level being different - I got used to preferred roots in OLS :)
Happy to keep COB if that's what you recommend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants