Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rates as independent microservice #13

Open
kabl opened this issue May 31, 2018 · 1 comment
Open

Rates as independent microservice #13

kabl opened this issue May 31, 2018 · 1 comment
Labels
feature New feature or request

Comments

@kabl
Copy link

kabl commented May 31, 2018

Why the Rates service is (at build time) technical bound to all other / very specific ICO services?
Why Rates service is not designed to be used in other projects (which not share same monitor or backend)?

    compile project(':commons:model')
    compile project(':commons:sql-repository')

These libraries have the entire Model and DB Entities inside which are not relevant for Rates. Even Rates DB Entities are in these libraries which are not relevant for the other services. E.g. Rates does not need to know about KycInfo.java and many other classes.

A microservice should not know about how an other microservice is persisting data.
Proposal:

  • Isolate rates from code sharing which is not needed. Especially on DB level you should not share Tables.
  • Keep Rates as independent Service. At code level and runtime
  • One Rates instance/deployment could be used by several ICOs.
  • Rates in a separate GIT Repo with own life cycle.
  • Rates could theoretical even use an own DB.

http://microservices.io/i/Microservice_Architecture.png

@gsmachado
Copy link
Member

Hello @kabl

Good feedback. We are planning to split the commons:model and commons:sql-repository, and move the parts to modules which are closely related to each other. Thanks!

However, suggestions like "Rates in a separate GIT Repo with own life cycle" and "Rates could theoretical even use an own DB" will not be done as a priority in the near future. But we are accepting pull requests! :-) :-) :-)

@gsmachado gsmachado added the feature New feature or request label Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants